Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include common labels in pod labels #3441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

include common labels in pod labels #3441

wants to merge 1 commit into from

Conversation

jhulick
Copy link

@jhulick jhulick commented Nov 21, 2024

What this PR does / why we need it:

  • it adds all common labels to metadata labels in the pod spec. The main reasoning is to persist the helm.sh/chart, app.kubernetes.io/version and app.kubernetes.io/name labels to the pod for standardization. Per docs, (https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels) "In order to take full advantage of using these labels, they should be applied on every resource object.".
  • to improve traceability throughout the application. Ex. via Kiali dashboard.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikh-Abubaker Sheikh-Abubaker Awaiting requested review from Sheikh-Abubaker Sheikh-Abubaker is a code owner

@dgzlopes dgzlopes Awaiting requested review from dgzlopes dgzlopes is a code owner

@swartz-k swartz-k Awaiting requested review from swartz-k swartz-k is a code owner

@BitProcessor BitProcessor Awaiting requested review from BitProcessor BitProcessor is a code owner

@faustodavid faustodavid Awaiting requested review from faustodavid faustodavid is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhulick @CLAassistant